[webkit-reviews] review granted: [Bug 93390] Allow blocking of third-party localStorage and sessionStorage : [Attachment 157780] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 93390: Allow blocking of third-party localStorage and sessionStorage
https://bugs.webkit.org/show_bug.cgi?id=93390

Attachment 157780: Patch
https://bugs.webkit.org/attachment.cgi?id=157780&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157780&action=review


> Source/WebCore/page/SecurityOrigin.cpp:414
> +bool SecurityOrigin::isThirdParty(const SecurityOrigin* other) const

other -> child

> Source/WebCore/page/SecurityOrigin.h:143
> +    bool isThirdParty(const SecurityOrigin*) const;

This function is asymmetric, but it's not clear which argument is which. 
Perhaps we should label the parameter "child" to make that clear?

Also, can we move this function to the "private" section?  It's better if
callers use a "can" function rather than calling this function directly.

> Source/WebCore/testing/InternalSettings.cpp:626
> +    settings()->setThirdPartyStorageBlockingEnabled(enabled);

I guess this setting already exists?