[webkit-reviews] review requested: [Bug 93623] [CSS Shaders] Add blend mode and composite op to compiled program cache key : [Attachment 157779] Patch

[bugzilla-daemon at webkit.org]

Max Vujovic <mvujovic at adobe.com> has asked  for review:
Bug 93623: [CSS Shaders] Add blend mode and composite op to compiled program
cache key
https://bugs.webkit.org/show_bug.cgi?id=93623

Attachment 157779: Patch
https://bugs.webkit.org/attachment.cgi?id=157779&action=review

------- Additional Comments from Max Vujovic <mvujovic at adobe.com>
(In reply to comment #6)
> (From update of attachment 157583 [details])
> Do you need to create a new header for this struct? Can't you put it into
CustomFilterProgramInfo.h? Other than that the patch looks fine.

It doesn't need a new header file. I've updated the patch and moved it to
CustomFilterProgramInfo.h.

I've also made one other change since the last patch. I've added
m_mixSettings.enabled to the hash because I realized the following (a) and (b)
were hashing to the same value without it:

(a)
m_mixSettings.enabled=1
m_mixSettings.blendMode=0
m_mixSettings.compositeOperator=0

(b)
m_mixSettings.enabled=0
m_mixSettings.blendMode=anything
m_mixSettings.compositeOperator=anything