[webkit-reviews] review granted: [Bug 90555] [NRWT] Compare results between different platforms : [Attachment 157721] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 90555: [NRWT] Compare results between different platforms
https://bugs.webkit.org/show_bug.cgi?id=90555

Attachment 157721: proposed fix
https://bugs.webkit.org/attachment.cgi?id=157721&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157721&action=review


looks great! thanks!

> Tools/Scripts/webkitpy/layout_tests/port/base.py:216
> +    def compare_baseline(self):

minor nit: I might name this _compare_baseline() since I don't want this to be
public ...