[webkit-reviews] review requested: [Bug 91660] Text Autosizing: Increase line height in proportion to font size. : [Attachment 157761] Patch

[bugzilla-daemon at webkit.org]

John Mellor <johnme at chromium.org> has asked  for review:
Bug 91660: Text Autosizing: Increase line height in proportion to font size.
https://bugs.webkit.org/show_bug.cgi?id=91660

Attachment 157761: Patch
https://bugs.webkit.org/attachment.cgi?id=157761&action=review

------- Additional Comments from John Mellor <johnme at chromium.org>
Ok, after an in depth discussion with jchaffraix I've got a much better
understanding of how things work and the best way to proceed. This patch
reverts to the approach taken by the first patch I uploaded on this bug, but
does so in a cleaner, simpler way (notably, without adding an unnecessary
specifiedLineHeight field to RenderStyle, as instead this is derived
automatically from the textAutosizingMultiplier). The added Layout Tests now
all pass, and the rendering looks good even on relatively complex pages like
wikipedia articles. This is now ready for review.