[webkit-reviews] review canceled: [Bug 90958] [css3-text] Add support for text-decoration-style : [Attachment 157732] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled  review:
Bug 90958: [css3-text] Add support for text-decoration-style
https://bugs.webkit.org/show_bug.cgi?id=90958

Attachment 157732: Patch
https://bugs.webkit.org/attachment.cgi?id=157732&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
A general comment, it's better to split parsing from actually implementing the
feature which requires some flag (either compile or runtime) to avoid breaking
CSS feature detection. This makes it easier for different domain experts to
comment separately on the patch. On top of that, you wouldn't end up with a
massive patch that reviewers usually avoid.

Here as you expose the feature to the web, it is expected to work properly
which is more difficult to get right than an incremental approach. Under this
assumption, this patch needs another round.