[webkit-reviews] review granted: [Bug 93706] Support creating File object from FileSystem URL for files in FileSystem API : [Attachment 157729] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 93706: Support creating File object from FileSystem URL for files in
FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=93706

Attachment 157729: Patch
https://bugs.webkit.org/attachment.cgi?id=157729&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157729&action=review


> Source/Platform/chromium/public/WebBlobData.h:53
> +	   WebURL url; // For Blob or URL.

nit: "For TypeBlob or TypeURL." just to make it really clear.

> Source/Platform/chromium/public/WebHTTPBody.h:57
> +	   WebURL url; // For Blob or URL type.

nit: "For TypeBlob or TypeURL." just to make it really clear.

> Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:157
> +    ASSERT(KURL(blobURL).protocol() == "blob");

nit: use KURL's protocolIs method.