[webkit-reviews] review denied: [Bug 90661] Distributed nodes should not share styles. : [Attachment 154245] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 90661: Distributed nodes should not share styles.
https://bugs.webkit.org/show_bug.cgi?id=90661

Attachment 154245: Patch
https://bugs.webkit.org/attachment.cgi?id=154245&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154245&action=review


> Source/WebCore/css/StyleResolver.cpp:1717
> +    bool elementIsDistributed = false;

How about elementIsDistributed -> distributedToInsertionPoint?

This may be a bit more clear to non-shadow DOM users.

> Source/WebCore/css/StyleResolver.cpp:1720
> +    if (Element* parentElement = element->parentElement())
> +	   if (ElementShadow* shadow = parentElement->shadow())
> +	       elementIsDistributed = !!shadow->insertionPointFor(element);

Since this is only checked once, it might be better to just move it to a static
free-standing function that is only called when the first part of the condition
below is true.