[webkit-reviews] review granted: [Bug 93648] [Qt] Add support for HTML5 state object history API in FrameLoaderClientQt : [Attachment 157735] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 93648: [Qt] Add support for HTML5 state object history API in
FrameLoaderClientQt
https://bugs.webkit.org/show_bug.cgi?id=93648

Attachment 157735: Patch
https://bugs.webkit.org/attachment.cgi?id=157735&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157735&action=review


> Source/WebKit/qt/ChangeLog:8
> +	   Add support for push/replace/pop by implementing
dispatchDidNavigateWithinPage.

Basically all you are doing it to make sure the urlChanged signal is fired etc,
all the history() methods already have the right state.