[webkit-reviews] review granted: [Bug 93601] [BlackBerry] Tap highlight flashes checkerboard after pinch zoom : [Attachment 157708] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Arvid Nilsson
<anilsson at rim.com>'s request for review:
Bug 93601: [BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601

Attachment 157708: Patch
https://bugs.webkit.org/attachment.cgi?id=157708&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157708&action=review


I will r+ to sync up downstream and upstream, but please consider my comment as
a follow-up, if you agree.

> Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:165
> +    // This layer is typically small enough that we can afford to cache all
tiles and never
> +    // risk checkerboarding.
> +    return true;

it can be big enough: think of a <a><img/></a> on facebook. If zoomed in it
easily takes the whole screen. Should we have a threshold?