[webkit-reviews] review granted: [Bug 93615] [V8] Introduce V8DOMConfiguration class and make batchConfigureXXX() methods static : [Attachment 157622] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93615: [V8] Introduce V8DOMConfiguration class and make batchConfigureXXX()
methods static
https://bugs.webkit.org/show_bug.cgi?id=93615

Attachment 157622: Patch
https://bugs.webkit.org/attachment.cgi?id=157622&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157622&action=review


> Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:37
> +						    
v8::Handle<v8::ObjectTemplate> proto, 

I would clean up all these names too.  e.g., proto -> prototype

> Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:67
> +v8::Local<v8::Signature>
V8DOMConfiguration::configureTemplate(v8::Persistent<v8::FunctionTemplate>
desc,

desc -> functionDescriptor

> Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:68
> +								  const char
*interfaceName,

"const char *" -> "const char*"

> Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:70
> +								  int
fieldCount,

int -> size_t ?

> Source/WebCore/bindings/v8/V8DOMConfiguration.h:53
> +	   bool onProto;

onProto -> onPrototype

> Source/WebCore/bindings/v8/V8DOMConfiguration.h:63
> +					     v8::Handle<ObjectOrTemplate>
proto,

proto -> prototype

> Source/WebCore/bindings/v8/V8DOMConfiguration.h:65
> +	   {

Bad indent