[webkit-reviews] review denied: [Bug 93693] [WK2] REGRESSION(125091): pixel results don't sow scrollbars anymore : [Attachment 157649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 00:30:19 PDT 2012


mitz at webkit.org has denied Balazs Kelemen <kbalazs at webkit.org>'s request for
review:
Bug 93693: [WK2] REGRESSION(125091): pixel results don't sow scrollbars anymore
https://bugs.webkit.org/show_bug.cgi?id=93693

Attachment 157649: Patch
https://bugs.webkit.org/attachment.cgi?id=157649&action=review

------- Additional Comments from mitz at webkit.org
This is not the right fix. Prior to r125091, WebPage had two functions for
taking snapshots, snapshotInViewCoordinates, which captured scroll bars (and
only the visible part of the document view) and snapshotInDocumentCoordinates,
which didn’t capture scroll bar (and could capture any part of the document
view). r125091 neglected to notice this difference and left only one function
which works similarly to the old snapshotInDocumentCoordinates, and made
WKBundlePageCreateSnapshotInViewCoordinates call into it.


More information about the webkit-reviews mailing list