[webkit-reviews] review granted: [Bug 77772] implement display: -webkit-inline-flex : [Attachment 157635] Patch

Thu Aug 9 23:53:51 PDT 2012

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 77772: implement display: -webkit-inline-flex
https://bugs.webkit.org/show_bug.cgi?id=77772

Attachment 157635: Patch
https://bugs.webkit.org/attachment.cgi?id=157635&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157635&action=review

Nice find! This might also be a significant perf improvement.

> LayoutTests/css3/flexbox/inline-flex.html:1
> +<!DOCTYPE html>

Nit: I'd prefer you just make this a regular check-layout.js test. You can use
inline-blocks instead of text and assert the size/position of the inline
flexbox.

We should use reftests if we really have to test paint behavior or something
like that.

Up to you though. Not a big deal.