[webkit-reviews] review granted: [Bug 93657] Recommend the use of https and mention git on building/checkout.html : [Attachment 157556] Updated per Mark's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 14:53:35 PDT 2012


Mark Rowe (bdash) <mrowe at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 93657: Recommend the use of https and mention git on building/checkout.html
https://bugs.webkit.org/show_bug.cgi?id=93657

Attachment 157556: Updated per Mark's comment
https://bugs.webkit.org/attachment.cgi?id=157556&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157556&action=review


r=me with the described changes.

> Websites/webkit.org/building/checkout.html:11
> +<div id="title">
> +<h1>The WebKit Open Source Project</h1>
> +</div>
> +
> +<div id="icon"></div>
> +
> +<div id="content">

These bits shouldn't be here.

> Websites/webkit.org/building/checkout.html:42
> +<a
href="http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2">http://nightly
.webkit.org/files/WebKit-SVN-source.tar.bz2</a>.  It is updated every six
hours. Note the archived checkout uses HTTP connection. We recommend running
the following command to use HTTPS instead:</p>

"the archived checkout uses HTTP connection" should be "the archived checkout
uses *an* HTTP connection"

> Websites/webkit.org/building/checkout.html:71
> +<p>If you want to be able to commit changes to the Subversion repository, or
just want to check out branches that aren't contained in WebKit.git, you will
need track the Subversion repository. To do this and working with other tools
on a Git checkout, read <a
href="http://trac.webkit.org/wiki/UsingGitWithWebKit">the wiki page</a>.</p>

The last sentence here reads very awkwardly. I'd suggest rephrasing it to
something like:
For information about this, and other aspects of using Git with WebKit, read
the wiki page.

The wiki link could also point to https://trac.webkit.org/ too.


More information about the webkit-reviews mailing list