[webkit-reviews] review granted: [Bug 92991] itemType.add should treat \t as a space : [Attachment 157492] Patch for review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 9 12:43:35 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <arko at motorola.com>'s
request for review:
Bug 92991: itemType.add should treat \t as a space
https://bugs.webkit.org/show_bug.cgi?id=92991
Attachment 157492: Patch for review
https://bugs.webkit.org/attachment.cgi?id=157492&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157492&action=review
> Source/WebCore/html/DOMTokenList.cpp:59
> + if (!isHTMLSpace(input[input.length()-1]))
I know this was also true in the old code but there should be a space around -.
>
LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:2
1
> + debug("PASS: " + description);
You can use testPassed.
>
LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:2
3
> + debug("FAIL: " + description + " expected '" + expected + "' but got
" + actual);
and testFailed.
>
LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:2
7
> +createElement('itemref', 'a ');
It looks as if itemref is an element name. Probably better to rename
createElement to createDivWithAttribute.
More information about the webkit-reviews
mailing list