[webkit-reviews] review granted: [Bug 90267] Handle SSL errors for SOUP : [Attachment 152205] Rebased to current git master

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 90267: Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267

Attachment 152205: Rebased to current git master
https://bugs.webkit.org/attachment.cgi?id=152205&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152205&action=review


> Source/WebCore/ChangeLog:18
> +	   (WebCore::ResourceError::ResourceError): Add new constrcutor for

constrcutor -> constructor

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:164
> +class HostTLSCertificates {

Maybe HostTLSCertificateSet to to make it clear that this is a set?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:166
> +    static const size_t sha1HashSize = 20;

This can be defined in the scope that it's used.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:175
> +    bool check(GTlsCertificate* certificate)

How about "contains" ?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:195
> +	   return base64Encode(reinterpret_cast<const char*>(digest.data()),
sha1HashSize);

It's a bit surprising that base64Encode does not return a CString.