[webkit-reviews] review granted: [Bug 92089] Web Inspector: Protocol Extension: Refactor protocol extension for CSS Regions : [Attachment 157452] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 05:50:54 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 92089: Web Inspector: Protocol Extension: Refactor protocol extension for
CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=92089

Attachment 157452: Patch
https://bugs.webkit.org/attachment.cgi?id=157452&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157452&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:454
> +    if (!assertDocument(errorString, documentNodeId))

Nit: you could also check whether node's document matches the one resolved.


More information about the webkit-reviews mailing list