[webkit-reviews] review canceled: [Bug 93598] [V8] Change v8Undefined() to v8Undefined(Isolate* isolate=0) : [Attachment 157427] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has canceled Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93598: [V8] Change v8Undefined() to v8Undefined(Isolate* isolate=0)
https://bugs.webkit.org/show_bug.cgi?id=93598

Attachment 157427: Patch
https://bugs.webkit.org/attachment.cgi?id=157427&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Looks like more investigation is required. In short:

- v8::Handle<v8::Value>() and v8::Undefined() are not equivalent, as I
mentioned before. There are some places where we must use v8::Undefined()
instead of v8::Handle<v8::Value>().

- I've thought that there would be no place where we must use
v8::Handle<v8::Value>() instead of v8::Undefined(). But this assumption was
wrong, which caused the test failures.

After organizing my thoughts, let me post a patch again.