[webkit-reviews] review requested: [Bug 89873] [WK2][GTK] Implement new API to save a web page using MHTML : [Attachment 157435] Patch Proposal + Unit Tests + Documentation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 05:05:27 PDT 2012


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 89873: [WK2][GTK] Implement new API to save a web page using MHTML
https://bugs.webkit.org/show_bug.cgi?id=89873

Attachment 157435: Patch Proposal + Unit Tests + Documentation
https://bugs.webkit.org/attachment.cgi?id=157435&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching new version of the patch addressing issues pointed out by Carlos.

Notice that, as per the creation of a new class SaveWebViewText : WebViewTest,
the global variables for the name of the temporary file and directory are not
needed anymore, since those now belong to that new class (and so will be
created and freed in the normal lifecycle for that test).


More information about the webkit-reviews mailing list