[webkit-reviews] review granted: [Bug 93572] Append the unit in place when generating the text value of a CSSPrimitiveValue : [Attachment 157379] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 93572: Append the unit in place when generating the text value of a
CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=93572

Attachment 157379: Patch
https://bugs.webkit.org/attachment.cgi?id=157379&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157379&action=review


r=me, great idea.

> Source/WebCore/css/CSSPrimitiveValue.cpp:835
> -    StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal());
> +    StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal() +
suffixLength);

Could this also be made to use LChar/8-bit strings?