[webkit-reviews] review denied: [Bug 93556] Color suggestion popup shows up in wrong locations : [Attachment 157411] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 9 01:06:54 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93556: Color suggestion popup shows up in wrong locations
https://bugs.webkit.org/show_bug.cgi?id=93556
Attachment 157411: Patch
https://bugs.webkit.org/attachment.cgi?id=157411&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157411&action=review
> Source/WebKit/chromium/src/ColorChooserUIController.cpp:95
> - return WebCore::IntSize(300, 300);
> + return WebCore::IntSize(0, 0);
Would you update CalendarPickerElement::contentSize too please?
> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:241
> + m_isPutAboveOrigin = true;
We can remove WebPagePopupImpl::m_isPutAboveOrigin.
More information about the webkit-reviews
mailing list