[webkit-reviews] review denied: [Bug 93444] Web Inspector: SourceFrame shouldn't be a View : [Attachment 157288] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Jan Keromnes
<janx at chromium.org>'s request for review:
Bug 93444: Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444

Attachment 157288: Patch
https://bugs.webkit.org/attachment.cgi?id=157288&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157288&action=review


Looks like it is almost ready.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:66
> +    show: function(parent)

Just nuke the entire method.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:74
>	   this._popoverHelper.hidePopover();

This should go into the willHide listener (and be done every time we hide)

> Source/WebCore/inspector/front-end/SourceFrame.js:112
> +	   //WebInspector.View.prototype.willHide.call(this);

nuke this line