[webkit-reviews] review denied: [Bug 93401] Remove uses of ClassInfo in StrictEq and CompareEq in the DFG : [Attachment 157290] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 93401: Remove uses of ClassInfo in StrictEq and CompareEq in the DFG
https://bugs.webkit.org/show_bug.cgi?id=93401

Attachment 157290: Patch
https://bugs.webkit.org/attachment.cgi?id=157290&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
/Volumes/Data/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:1620:
warning: empty body in an if-statement
/Volumes/Data/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:1630:
warning: empty body in an if-statement

Two more tweaks:

(1) When we detect a "masquerades" object, it should only masquerade in code
from its same global object / document.

(2) The baseline JIT and interpreter should obey the same rules.

Please add a test case for the cross-document case, as well.