[webkit-reviews] review granted: [Bug 93305] Add optional debug logging for tiled scrolling : [Attachment 157373] typo'd 'layer' for 'sublayer'

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 93305: Add optional debug logging for tiled scrolling
https://bugs.webkit.org/show_bug.cgi?id=93305

Attachment 157373: typo'd 'layer' for 'sublayer'
https://bugs.webkit.org/attachment.cgi?id=157373&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157373&action=review


> Source/WebCore/platform/graphics/ca/mac/TileCache.h:71
> +    IntRect visibleRect() { return m_visibleRect; }

const

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:317
> +    Vector<RetainPtr<WebTileLayer> > tiles(m_tiles.size());

Vector<RetainPtr<WebTileLayer> > could use a typedef.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:323
> +unsigned TileCache::blankPixelCountForTiles(Vector<RetainPtr<WebTileLayer> >
tiles, IntRect visibleRect, IntPoint tileTranslation)

Please pass the vector by const reference.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:327
> +    for (Vector<RetainPtr<WebTileLayer> >::const_iterator it =
tiles.begin(), end = tiles.end(); it != end; ++it) {

Does declaring end here work on all versions of gcc/clang we care about? We
don't normally do it this way.