[webkit-reviews] review granted: [Bug 93393] Overflow regions sometimes repaint incorrectly after going into or coming out of compositing mode : [Attachment 157319] Crash fix

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 93393: Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
https://bugs.webkit.org/show_bug.cgi?id=93393

Attachment 157319: Crash fix
https://bugs.webkit.org/attachment.cgi?id=157319&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157319&action=review


> Source/WebCore/ChangeLog:13
> +	   My first patch to fix this bug removed an if (parent()) check that
is 
> +	   needed to prevent a table crash. This patch adds that check back,
but 
> +	   really we should delay the computation of repaint rects if layout
has 

I think it would be good if this text referenced the test that was crashing,
and changeset that added the origina if (parent()) check.