[webkit-reviews] review requested: [Bug 93405] [CSS Shaders] Invalid shaders should act as pass-through filters : [Attachment 157317] Patch V3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 8 16:00:31 PDT 2012
Chiculita Alexandru <achicu at adobe.com> has asked for review:
Bug 93405: [CSS Shaders] Invalid shaders should act as pass-through filters
https://bugs.webkit.org/show_bug.cgi?id=93405
Attachment 157317: Patch V3
https://bugs.webkit.org/attachment.cgi?id=157317&action=review
------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Posting it back for review because I've added more code for Safari Mac. It
seems like the generated expected result had slightly different colors. I
suppose that's coming from the FilterEffect data conversion back to an
ImageBuffer. I've added a "grayscale(0)" effect on the images in the expected
result, just to trigger the same kind of errors on the generated image.
More information about the webkit-reviews
mailing list