[webkit-reviews] review granted: [Bug 93402] Use char* instead of LChar* for the public interface of String construction from literals : [Attachment 157028] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 15:40:19 PDT 2012


Michael Saboff <msaboff at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 93402: Use char* instead of LChar* for the public interface of String
construction from literals
https://bugs.webkit.org/show_bug.cgi?id=93402

Attachment 157028: Patch
https://bugs.webkit.org/attachment.cgi?id=157028&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157028&action=review


> Source/WTF/wtf/text/StringImpl.cpp:87
> +    ASSERT(charactersAreAllASCII<LChar>(reinterpret_cast<const
LChar*>(characters), length));

Do we care about the ASSERT after this change?


More information about the webkit-reviews mailing list