[webkit-reviews] review granted: [Bug 93532] Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors : [Attachment 157305] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 93532: Make isTransparentSilverlightBackgroundValue handle all the possible
transparent colors
https://bugs.webkit.org/show_bug.cgi?id=93532

Attachment 157305: Patch
https://bugs.webkit.org/attachment.cgi?id=157305&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157305&action=review


> Source/WebKit2/ChangeLog:6
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

oops

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:-554
> -    // FIXME: We should handle all the cases from
http://msdn.microsoft.com/en-us/library/cc838148(VS.95).aspx here

I'd like this url to remain in the comment so I can see where this crazy
"ScRGB" stuff comes from.