[webkit-reviews] review granted: [Bug 93059] [chromium] Refactor tile flags. : [Attachment 157283] rebase

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Eric Penner
<epenner at chromium.org>'s request for review:
Bug 93059: [chromium] Refactor tile flags.
https://bugs.webkit.org/show_bug.cgi?id=93059

Attachment 157283: rebase
https://bugs.webkit.org/attachment.cgi?id=157283&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157283&action=review


R=me.

> Source/WebCore/ChangeLog:34
> +	   As a last step I was going to merge LayerChromium::update() and
> +	   LayerChromium::needsMoreUpdates() by having update() just return
> +	   a boolean, but this proved to be a big change so I'm holding off
> +	   on that. That would let us remove the m_failedPaint and get rid
> +	   of needsIdlePaint() altogether.

This sounds nice, especially since needsMoreUpdates() has to do a lot of the
same work that update() could already figure out.

> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:432
> +    for (int j = top; j <= bottom; ++j) {
> +	   for (int i = left; i <= right; ++i) {
> +	       UpdatableTile* tile = tileAt(i, j);
> +	       ASSERT(tile); // Did setTexturePriorites get skipped?
> +	       // FIXME: This should not ever be null.
> +	       if (!tile)
> +		   continue;

This seven line copy and pasted boilerplate makes me a little sad.