[webkit-reviews] review granted: [Bug 93508] Make the Silverlight CAOpenGLLayer opaque if we know the plug-in contents is opaque to reduce blending : [Attachment 157273] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 93508: Make the Silverlight CAOpenGLLayer opaque if we know the plug-in
contents is opaque to reduce blending
https://bugs.webkit.org/show_bug.cgi?id=93508

Attachment 157273: Patch
https://bugs.webkit.org/attachment.cgi?id=157273&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157273&action=review


> Source/WebKit2/Shared/Plugins/PluginQuirks.h:48
> +	   // NPPVpluginTransparentBool, so we'll always force it unless the
plug-in has a "background"
> +	   // attribute that specifies a opaque color.
> +	   MakeOpaqueUnlessTransparentSilverlightBackgroundAttributeExists,

It might be worth noting in this comment that the docs say "a null value for
the Background property of the Silverlight plug-in is interpreted as the named
color White.", so no colorValue param means opaque.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:557
> +    if (backgroundValue == "#000000")
> +	   return false;

This is fragile, as it would break if the content changed. Sucks that these
aren't CSS colors :(