[webkit-reviews] review canceled: [Bug 93482] [BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable for in-region scroll : [Attachment 157251] patch - fixed konrad's suggestions

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has canceled Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 93482: [BlackBerry] Tie up the scrolling machinery to  the graphics tree
when applicable for in-region scroll
https://bugs.webkit.org/show_bug.cgi?id=93482

Attachment 157251: patch - fixed konrad's suggestions
https://bugs.webkit.org/attachment.cgi?id=157251&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
> > Source/WebKit/blackberry/Api/InRegionScroller.h:32
> > +
> 
> Empty line not needed.

Fixed

> > Source/WebKit/blackberry/Api/InRegionScroller_p.h:22
> > +#include "IntRect.h"
> 
> Is this actually used?

Yes and no, but I replaced by IntSize.h and IntPoint.h to be explicit.
 
> > Source/WebKit/blackberry/Api/InRegionScroller_p.h:29
> > +class LayerCompositingThread;
> 
> Does not seem used?

No, removed.

> > Source/WebKit/blackberry/Api/InRegionScroller_p.h:40
> > +
> 
> Empty line not needed

Fixed.

> > Source/WebKit/blackberry/Api/InRegionScroller_p.h:57
> > +private:
> 
> I wonder if we need private in this class.

Although it is uncommon and I agree to generally make all member of private
classes asa public, I do not want these private methods to be called at all by
anyone else. They are internal helpers.