[webkit-reviews] review granted: [Bug 93208] [jhbuild] move md5sum checking to update-webkit-libs-jhbuild : [Attachment 156570] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 93208: [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=93208

Attachment 156570: Patch
https://bugs.webkit.org/attachment.cgi?id=156570&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156570&action=review


Looks good, but I have a couple concerns below...

> Tools/Scripts/update-webkit-libs-jhbuild:50
> +    # Read the whole file.

You can probably omit this comment.

> Tools/Scripts/update-webkit-libs-jhbuild:63
> +    foreach my $file (qw(jhbuildrc.md5sum jhbuild.modules.md5sum)) {

It seems a bit less expensive and logical to start with the base names and then
append ".md5sum" for the frozen version of the md5sum, like in saveJhbuildMd5.

> Tools/Scripts/webkitdirs.pm:1924
> +    unshift(@buildArgs, jhbuildWrapperPrefixIfNeeded());

Will this do the right thing if the WebKit jhbuild isn't used? It adds an empty
string to the front of the array.