[webkit-reviews] review granted: [Bug 93413] [WK2] MiniBrowser crashes on window.open() : [Attachment 157049] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 09:26:19 PDT 2012


mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 93413: [WK2] MiniBrowser crashes on window.open()
https://bugs.webkit.org/show_bug.cgi?id=93413

Attachment 157049: proposed fix
https://bugs.webkit.org/attachment.cgi?id=157049&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=157049&action=review


>> Tools/MiniBrowser/mac/WebBundle/WebBundleMain.m:48
>> +	    CFRelease(cfURL);
> 
> Just out of curiousity, if cfURL can be a null pointer, isn't the previous
call to absoluteString in the LOG line going to crash?

It isn’t. Sending an Objective-C message to nil is safe.


More information about the webkit-reviews mailing list