[webkit-reviews] review canceled: [Bug 93371] Remove All Custom binding code for TypedArray. : [Attachment 157197] Updated Patch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has canceled Vineet Chaudhary
(vineetc) <rgf748 at motorola.com>'s request for review:
Bug 93371: Remove All Custom binding code for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93371

Attachment 157197: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=157197&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #11)
> (From update of attachment 157197 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=157197&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2218
> > -			 push(@implContent, "	 $implType* impl =
static_cast<$implType*>(castedThis->impl());\n");
> > +			 if (!($function->signature->name eq "set" and
$dataNode->extendedAttributes->{"TypedArray"})) {
> > +			     push(@implContent, "    $implType* impl =
static_cast<$implType*>(castedThis->impl());\n");
> > +			 }
> 
> Just like CodeGeneratorV8.pm, can you generate set() method here and early
return? Specifically, like this:

Done! 
 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3750
> > +		 if ($dataNode->extendedAttributes->{"CustomIndexedSetter"}) {
> 
> As you mentioned, let's remove it in a follow-up patch.
>
Yes sure!
 
> > Source/WebCore/bindings/scripts/IDLAttributes.txt:33
> > -ConstructorTemplate=Event
> > +ConstructorTemplate=*
> 
> ConstructorTemplate=Event|TypedArray

Thanks. Done.

> Please add the explanation to the WebKitIDL wiki after landing the patch.

Yes sure. Thanks :)