[webkit-reviews] review denied: [Bug 93278] QtWebKit fails to build with OpenGL support on QNX : [Attachment 157199] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 93278: QtWebKit fails to build with OpenGL support on QNX
https://bugs.webkit.org/show_bug.cgi?id=93278

Attachment 157199: Patch
https://bugs.webkit.org/attachment.cgi?id=157199&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157199&action=review


Seems like a hacky way of doing this. We already disable 3D_GRAPHICS on
windows, see code above in the same file.

> Tools/qmake/mkspecs/features/features.prf:258
> +    DEFINES -= ENABLE_3D_RENDERING=1
> +    DEFINES += ENABLE_3D_RENDERING=0

You don't need to disable this, it doesn't need 3D graphics.

> Tools/qmake/mkspecs/features/features.prf:260
> +    DEFINES -= ENABLE_WEBGL=1
> +    DEFINES += ENABLE_WEBGL=0

Not needed. This will be disabled by default if 3D_GRAPHICS is disabled.