[webkit-reviews] review denied: [Bug 93458] [Texmap] Render gif animation well. : [Attachment 157169] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 93458: [Texmap] Render gif animation well.
https://bugs.webkit.org/show_bug.cgi?id=93458

Attachment 157169: Patch
https://bugs.webkit.org/attachment.cgi?id=157169&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157169&action=review


Good catch, see comments.

> Source/WebCore/ChangeLog:12
> +	   No new tests, hard to write a test case.

Even harder to catch regressions later on... Please find the right test case
for this, e.g. changing the frame and then testing for pixels.

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:329
> +    NativeImagePtr newNativeImagePtr = image->nativeImageForCurrentFrame();

You need a null check.