[webkit-reviews] review granted: [Bug 93462] [Qt] Add unit test for QObject bindings for scriptable plugins : [Attachment 157182] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 93462: [Qt] Add unit test for QObject bindings for scriptable plugins
https://bugs.webkit.org/show_bug.cgi?id=93462

Attachment 157182: Patch
https://bugs.webkit.org/attachment.cgi?id=157182&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review


> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189
> +    TestPluginWidget()
> +    { }

why on separate line?

> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192
> +    int slotWithReturnValue() { return 42; }

Lovely number :-)

> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206
> +    virtual QObject *createPlugin(const QString &, const QUrl &, const
QStringList &, const QStringList &)

why not webkit style?