[webkit-reviews] review denied: [Bug 93371] Remove All Custom binding code for TypedArray. : [Attachment 157158] updatedPatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 02:22:34 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 93371: Remove All Custom binding code for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93371

Attachment 157158: updatedPatch
https://bugs.webkit.org/attachment.cgi?id=157158&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Marking r-, but the patch looks great.

- Remove [CustomConstructor] from all the IDLs, because they are no longer
"custom". Instead, let's introduce [ConstructorTemplate=TypedArray]. Look at
the implementation of [ConstructorTemplate=Event].

- Remove [TypedArray=...] from all set()s. Given that you are already
specifying [TypedArray=...] on the interface, CodeGenerators can use it.
Specifically, CodeGenerators can use
$dataNode->extendedAttributes->{"TypedArray"} instead of
$function->signature->extendedAttributes->{"TypedArray"}.


More information about the webkit-reviews mailing list