[webkit-reviews] review granted: [Bug 93377] Web Inspector: store last evaluation result in $_ : [Attachment 156962] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 93377: Web Inspector: store last evaluation result in $_
https://bugs.webkit.org/show_bug.cgi?id=93377

Attachment 156962: Patch
https://bugs.webkit.org/attachment.cgi?id=156962&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156962&action=review


Shouldn't we agree with firebug folks on this particular name for such a
variable?

> Source/WebCore/inspector/InjectedScriptSource.js:805
> +    this.$_ = injectedScript._lastResult;

nit: I'd use __defineGetter__ instead.