[webkit-reviews] review denied: [Bug 91630] Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously : [Attachment 156938] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 91630: Web Inspector: Incorrect XHR responses when two async xhrs are sent
synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Attachment 156938: Patch
https://bugs.webkit.org/attachment.cgi?id=156938&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156938&action=review


Please fix the tests.

> Source/WebCore/inspector/InspectorInstrumentation.h:175
> +    static void didReceiveResourceResponse(const
InspectorInstrumentationCookie&, unsigned long identifier, DocumentLoader*,
const ResourceResponse&, ResourceLoader* = 0);

nit: I don't think we should have default argument values for this method.

> Source/WebCore/loader/ResourceLoadNotifier.cpp:126
> +void ResourceLoadNotifier::dispatchDidReceiveResponse(DocumentLoader*
loader, unsigned long identifier, const ResourceResponse& r, ResourceLoader
*resourceLoader)

ResourceLoader* resourceLoader

> LayoutTests/http/tests/inspector/network-test.js:30
> +    doXHRWithPayload(method, url, async, payload, null);

callback is missing.