[webkit-reviews] review granted: [Bug 93429] Make slider tick mark snapping threshold configurable for each platform : [Attachment 157118] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93429: Make slider tick mark snapping threshold configurable for each
platform
https://bugs.webkit.org/show_bug.cgi?id=93429

Attachment 157118: Patch
https://bugs.webkit.org/attachment.cgi?id=157118&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157118&action=review


> Source/WebCore/rendering/RenderTheme.h:219
> +    virtual LayoutUnit sliderTickSnappingThreshold() const { return 0; }

nit: We had better put the function body to RenderTheme.cpp because inline
function definition for a virtual function wastes compilation cost.

>
LayoutTests/platform/chromium/fast/forms/datalist/range-snap-to-datalist-expect
ed.txt:1
> +Tests if clicking close to a tick mark snaps to it.

You had better mention the test result depends on
RenderTheme::sliderTickSnappingThreshold() value.