[webkit-reviews] review granted: [Bug 89872] [WK2] Add new C API to generate MHTML data from the UI process : [Attachment 149472] Patch proposal

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 89872: [WK2] Add new C API to generate MHTML data from the UI process
https://bugs.webkit.org/show_bug.cgi?id=89872

Attachment 149472: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=149472&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149472&action=review


> Source/WebKit2/UIProcess/API/C/WKPage.cpp:604
> +#ifdef __BLOCKS__
> +static void callGetContentsAsMHTMLDataBlockAndDispose(WKDataRef mhtmlData,
WKErrorRef error, void* context)
> +{
> +    WKPageGetContentsAsMHTMLDataBlock block =
(WKPageGetContentsAsMHTMLDataBlock)context;
> +    block(mhtmlData, error);
> +    Block_release(block);
> +}
> +
> +void WKPageGetContentsAsMHTMLData_b(WKPageRef pageRef, bool
useBinaryEncoding, WKPageGetContentsAsMHTMLDataBlock block)
> +{
> +    WKPageGetContentsAsMHTMLData(pageRef, useBinaryEncoding,
Block_copy(block), callGetContentsAsMHTMLDataBlockAndDispose);
> +}
> +#endif

We don't need this API, blocks don't work well with the C API since none of the
WK objects are captured by value.