[webkit-reviews] review granted: [Bug 93393] Overflow regions sometimes repaint incorrectly after going into or coming out of compositing mode : [Attachment 157006] Patch to make style bot happy

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 93393: Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
https://bugs.webkit.org/show_bug.cgi?id=93393

Attachment 157006: Patch to make style bot happy
https://bugs.webkit.org/attachment.cgi?id=157006&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157006&action=review


> Source/WebCore/rendering/RenderLayer.cpp:494
> +    computeRepaintRects();
> +    
> +    for (RenderLayer* layer = firstChild(); layer; layer =
layer->nextSibling())
> +	   layer->computeRepaintRectsIncludingDescendants();

I think this deserves a FIXME comment about how computeRepaintRects() has to
walk up the parent chain for every layer to compute the rects.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:537
> +	   // The layer's cached repaints rects are relative to the repaint
container, so change when

Not just this layer, but for all descendant layers for which this layer is a
repaint container.

Which suggests that we could possibly optimize this;
computeRepaintRectsIncludingDescendants() could avoid subtrees which are
themselves compositing (taking care to deal with the fact that it's walking
parent/child layers, not in z-order). But I think that could be done in a later
patch.