[webkit-reviews] review denied: [Bug 93255] [GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking enabled : [Attachment 156956] patch with style fix

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied tuxator at o2.pl's request for
review:
Bug 93255: [GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking
enabled
https://bugs.webkit.org/show_bug.cgi?id=93255

Attachment 156956: patch with style fix
https://bugs.webkit.org/attachment.cgi?id=156956&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156956&action=review


> Source/WebKit/gtk/WebCoreSupport/TextCheckerClientGtk.cpp:64
> -    GOwnPtr<gchar> utf8Text(g_utf16_to_utf8(const_cast<gunichar2*>(text),
length, 0, 0, 0));
> +    GOwnPtr<gchar> utf8Text(g_utf16_to_utf8(reinterpret_cast<const
gunichar2*>(text), length, 0, 0, 0));

I mentioned this to pfor via IRC, but I'll leave it here for posterity: I think
it might be necessary here to use  g_ucs4_to_utf8 instead of simply casting
32-bit characters to 16-bit.

> Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp:122
> -static void
webkit_spell_checker_enchant_spell_checker_interface_init(WebKitSpellCheckerInt
erface* interface)
> +static void
webkit_spell_checker_enchant_spell_checker_interface_init(WebKitSpellCheckerInt
erface* iface)

Yeah, I agree with Eric here. If we can't use interface, we should use
something like spellCheckerInterface.