[webkit-reviews] review granted: [Bug 93034] Unprefix window.webkitURL : [Attachment 156799] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 7 15:24:20 PDT 2012


Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 93034: Unprefix window.webkitURL
https://bugs.webkit.org/show_bug.cgi?id=93034

Attachment 156799: Patch
https://bugs.webkit.org/attachment.cgi?id=156799&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156799&action=review


> Source/WebCore/ChangeLog:9
> +	   (This patch doesn't remove webkitURL yet as Safari and Chrome has
exposed the URL for a while now.)

Is webkitURL exposed in Safari?

> LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html:8
> +description("Test instanceof functions and properties of URL.");

Might be better to mention both webkitURL and URL here.

>
LayoutTests/platform/chromium-win/compositing/geometry/object-clip-rects-assert
ion-expected.txt:-1
> -This testcase should not fire an assertion related to clip rects.

Why do you change this file?


More information about the webkit-reviews mailing list