[webkit-reviews] review granted: [Bug 93239] [V8] Factor out V8Binding methods about configuring DOM attributes and methods : [Attachment 156635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 7 15:22:24 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93239: [V8] Factor out V8Binding methods about configuring DOM attributes
and methods
https://bugs.webkit.org/show_bug.cgi?id=93239

Attachment 156635: Patch
https://bugs.webkit.org/attachment.cgi?id=156635&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I would take this opportunity to change these files into WebKit style (e.g.,
not 80 column).

Consider turning these functions into static functions in a class:

V8DOMConfiguration::batchConfigureAttributes(...)

You don't have to do these things, but it's nice to clean up this stuff as we
touch it.


More information about the webkit-reviews mailing list