[webkit-reviews] review granted: [Bug 93334] [V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to ScriptController : [Attachment 156861] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 7 14:59:46 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93334: [V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to
ScriptController
https://bugs.webkit.org/show_bug.cgi?id=93334
Attachment 156861: Patch
https://bugs.webkit.org/attachment.cgi?id=156861&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156861&action=review
> Source/WebCore/bindings/v8/ScriptController.cpp:183
> void ScriptController::setIsolatedWorldSecurityOrigin(int worldID,
PassRefPtr<SecurityOrigin> securityOrigin)
A better name for this function is something like
setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming
crazy in this patch.
More information about the webkit-reviews
mailing list