[webkit-reviews] review granted: [Bug 93398] [chromium] Use WebCompositor interface in Platform API instead of CCProxy to query threaded compositor status : [Attachment 157013] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 93398: [chromium] Use WebCompositor interface in Platform API instead of
CCProxy to query threaded compositor status
https://bugs.webkit.org/show_bug.cgi?id=93398

Attachment 157013: Patch
https://bugs.webkit.org/attachment.cgi?id=157013&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157013&action=review


>> Source/Platform/chromium/public/WebCompositor.h:53
>> +	WEBKIT_EXPORT static bool onCompositorThread();
> 
> this feels a little bit skeevy. The implementation code is currently all
guarded by #ifndef NDEBUG, and the only caller to this is doing an ASSERT(). 
One option would be to hide the API itself behind debug-only compile time
guards, or decide that the callsite isn't really worth having the API (it's in
WebMediaPlayerClientImpl if you want to take a look).

I'd probably just remove it.