[webkit-reviews] review denied: [Bug 89722] Implement undoManager's undo, redo, length, position, clearUndo, and clearRedo : [Attachment 156794] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 89722: Implement undoManager's undo, redo, length, position, clearUndo, and
clearRedo
https://bugs.webkit.org/show_bug.cgi?id=89722

Attachment 156794: Patch
https://bugs.webkit.org/attachment.cgi?id=156794&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156794&action=review


> Source/WebCore/editing/UndoManager.cpp:121
> +    m_isInProgress = false;
> +
> +    m_undoStack.append(m_inProgressEntry.release());
> +    m_redoStack.removeLast();

Right, but nothing is keeping the whole UndoManager alive.  All these writes
are to potentially unallocated memory.