[webkit-reviews] review canceled: [Bug 93248] [V8] Remove custom toV8() calls for TypedArray. : [Attachment 156683] UpdatedPatch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has canceled Vineet Chaudhary
(vineetc) <rgf748 at motorola.com>'s request for review:
Bug 93248: [V8] Remove custom toV8() calls for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93248

Attachment 156683: UpdatedPatch
https://bugs.webkit.org/attachment.cgi?id=156683&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
> Nit: Please just confirm that WebGL tests pass.

I just checked webgl tests running and got few IMAGE Mismatch failures but both
were same
with and without this patch. IMO This should not cause any regression as there
are no
behavioural changes.

> New failing tests:
> http/tests/cache/post-with-cached-subresources.php

This shouldn't be because of these changes.

> +sub GetTypedArrayView
>"GetTypeNameOfExternalTypedArray" might be a better name.
Done.

> For readability and maintainability, I would prefer the following code:
>  return "v8::kExternalByteArray" if ...;
>  return "v8::kExternalPixelArray" if ...; .. 
Done.