[webkit-reviews] review granted: [Bug 91813] IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString : [Attachment 156835] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 20:14:12 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Xingnan Wang
<xingnan.wang at intel.com>'s request for review:
Bug 91813: IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Attachment 156835: Patch
https://bugs.webkit.org/attachment.cgi?id=156835&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156835&action=review


> Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:209
> +    EXPECT_EQ(static_cast<size_t>(9),
encodeVarInt(0x7fffffffffffffffll).size());

Nit: LL is better than ll. (l is confusing with 1.)


More information about the webkit-reviews mailing list